Skip to content

Remove println deprecation message#123

Merged
j-mao merged 1 commit into
masterfrom
hotfix-saturn
Jan 13, 2023
Merged

Remove println deprecation message#123
j-mao merged 1 commit into
masterfrom
hotfix-saturn

Conversation

@j-mao
Copy link
Copy Markdown
Member

@j-mao j-mao commented Jan 13, 2023

@j-mao j-mao requested review from andywang02, n8kim1 and pv711 January 13, 2023 07:19
n8kim1
n8kim1 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@n8kim1 n8kim1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(lol the top two methods didn't even print the right name)

looks sane ig, noting that

  • If this truly is deprecated we should consider still making that warning somewhere but idk where
  • there are other prints; hopefully these are the borked ones?

@j-mao j-mao merged commit b74f29d into master Jan 13, 2023
@j-mao j-mao deleted the hotfix-saturn branch January 13, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@n8kim1 n8kim1 n8kim1 approved these changes

@pv711 pv711 Awaiting requested review from pv711

@andywang02 andywang02 Awaiting requested review from andywang02

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Saturn running out of disk space

2 participants

@j-mao @n8kim1